refactor: remove dead code and stale references#2996
Merged
Conversation
- Remove `export` from `getTerminalWidth` in commands/info.ts — only used internally, not exported from commands/index.ts barrel - Remove `export` from `makeDockerExec` in shared/orchestrate.ts — only used internally by `makeDockerRunner`, no external callers - Bump CLI version to 0.26.6
louisgv
approved these changes
Mar 26, 2026
Member
louisgv
left a comment
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: b4e2c82
Findings
No security issues found. Changes are safe refactoring:
- Reduced API surface by making 2 unused exported functions private
- No command injection, credential leaks, or other vulnerabilities
- Version bump appropriate for scope of changes
Tests
- bash -n: N/A (no shell scripts modified)
- bun test: workspace dependency issue in worktree (expected), but lint passes
- biome lint: PASS (0 errors)
- curl|bash: N/A (no shell scripts modified)
- macOS compat: N/A (no shell scripts modified)
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exportfromgetTerminalWidthincommands/info.ts— function is only used internally within the file and was never exported from thecommands/index.tsbarrelexportfrommakeDockerExecinshared/orchestrate.ts— function is only used internally bymakeDockerRunnerwithin the same file, has no external callersScan results
Dead code found:
getTerminalWidth(commands/info.ts): exported but 0 external callers, not in barrelmakeDockerExec(shared/orchestrate.ts): exported but 0 external callersNo issues found:
python3 -c,python -c) usage: none-- qa/code-quality